[anchapin]

Enhance macOS support by adding ARM architecture builds and updating CI configurations. Update README with build instructions for ARM and Intel. Modify CMakeLists to handle architecture-specific package names. Improve dependency management in build script for architecture detection.

[Copilot]

Pull Request Overview

Enhance macOS support by adding ARM64 builds and adjusting build, packaging, CI, and docs to handle both Intel and ARM architectures.

• Introduce CMAKE_OSX_ARCHITECTURES-based arch detection in tasks/build.js with x64 fallback.
• Add ARM64 entries to manifest.json and normalize type casing.
• Update CMakeLists, CI workflow, and README to build and package separately for arm64 and x86_64.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tasks/build.js	Use env var for architecture, add fallback lookup, log platform/arch
manifest.json	Added macOS ARM64 dependency entries and unified type values
CMakeLists.txt	Customize CPACK package name for arm64 vs x86_64
.github/workflows/build_pat.yaml	Split macOS jobs into Intel/ARM, install Qt IFW via aqtinstall
README.md	Document separate ARM64 and Intel build commands and DMG names
app/.../reportsController.js,*	Fixed path-replacement regex
app/.../projectService.js,*	Fixed path-replacement regex
app/.../osServerService.js,*	Simplified quoting in CLI commands
app/.../analysisController.js,*	Switched to arrow callbacks, updated let to const, fixed regex

\

Comments suppressed due to low confidence (4)

.github/workflows/build_pat.yaml:139

• On GitHub Actions Windows runners the default shell is PowerShell, where %N% won’t expand; either switch to cmd or use $Env:N for PowerShell.

        cmake --build . --target package -j %N% --config Release

.github/workflows/build_pat.yaml:22

• [nitpick] You’ve defined both matrix.name and matrix.include; consider removing the top-level name list and relying solely on include for clarity.

        name: [Ubuntu, macOS-Intel, macOS-ARM, Windows_2022]

README.md:89

• [nitpick] The indentation of the new ARM64/Intel blocks is inconsistent with surrounding items; aligning the bullet level and code fences will improve readability.

			**Note:** For ARM64 (Apple Silicon) specific builds, use:

manifest.json:85

• You changed type to lowercase here; ensure all code that consumes this field is case-insensitive or updated to match.

    "type": "openstudio"

[anchapin]

At this point I need to test the Mac Arm installer locally and potentially simplify the code changes in this PR. Then this PR can merge.

[anchapin]

Rebased onto develop (a17cca5) and cleaned up the macOS ARM64 installer changes.

Tracked upstream dependency fixes required before merging:

• Build and export native macOS ARM64 (darwin-arm64) OpenStudio-server tarball in CI for OpenStudio-PAT OpenStudio-server#884 — Build and export native macOS ARM64 (darwin-arm64) OpenStudio-server tarball in CI for OpenStudio-PAT
• Conan Ruby 3.2.2 darwin tarballs: rubygems.rb eager spec_fetcher require breaks Bundler default gem activation & strip AppleDouble files OpenStudio#5666 — Conan Ruby 3.2.2 darwin tarballs: rubygems.rb eager spec_fetcher require & AppleDouble ._* files