Repository navigation
deps: remove request, request-progress, gulp-angular-templatecache (#339, safe subset) - #345
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
anchapin
force-pushed
the
deps/339-deprecated-npm
branch
from
October 14, 2026 21:02
4629926 to
e2c0f6a
Compare
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #339 (partial; does not close it — gulp 5 / eslint / ng-annotate / sourcemaps paths remain).
Changes
tasks/build.js:downloadDepsuses built-infetch+ stream pipeline (progress when content-length known, non-2xx -> error, 5s idle/connect timeout via AbortController, partial file removed on failure). Now returns a Promise. CRLF preserved.tasks/templateCache.js: small local gulp plugin replacing gulp-angular-templatecache. Verified byte-identical output (250551 bytes) vs the old plugin onapp/app/**/*.htmlwith modulePAT, rootapp.request,request-progress,gulp-angular-templatecache, and now-unusedvinyl-source-stream; added explicitjsesc(~2.5.2, same version as before) andvinyl(~2.2.1, already in tree).app/untouched (22).Tested locally (Apple Silicon, Node 18 via npx):
npm ci;npm run test:buildOK;gulp installDepsreal download+extract OK for ruby; bad endpoint -> HTTP 403 error surfaced. Note: rootpostinstall(npm installin app/) rewritesapp/package-lock.json(pre-existing; I reverted that).Not verified: Windows/Intel mac download, Playwright UI tests (#290).
Test plan: CI Build_PAT (all OSes) incl.
npm ci+ build; manualnpx gulp installDeps.Rollback: revert commit.
Duck review (addressed/noted): worth doing (removes deprecated
requesttree). Known behavior change: Node fetch does not honor HTTP(S)_PROXY env likerequestdid — proxy-basedinstallDepsunsupported (documented limitation; follow up if needed). templateCache emits no file for empty input (old plugin emitted an empty wrapper); n/a since partials always exist. Lockfile has some npm-version dedupe churn beyond the removals. No fixture/timeout tests added (manual only); follow-up candidate.