Repository navigation
ci: pin IFW 4.3.0 SHA-256 and add workflow_dispatch full-package path (#341, partial) - #347
Merged
Merged
Conversation
Collaborator
Author
|
Full-package dispatch run 38501699598 on this branch: green on macOS, Windows_2022 and Ubuntu; IFW SHA-256 check passed ( |
…ackage builds (#341) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
anchapin
force-pushed
the
deps/341-ifw-pin-dispatch
branch
from
October 14, 2026 21:01
4e6691a to
9c0c4dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #341 (partial; does not close it).
Changes (build_pat.yaml only; CRLF preserved)
curl -fL+ SHA-256 verification (hashes match Qt's published.sha256files for 4.3.0).workflow_dispatch: gives a deliberate non-PR full-package + artifact-upload path (plan item 5), since PRs only buildPAT(ci: faster PR builds (skip IFW packaging on PRs, npm cache, concurrency) #336).Deliberately not done (needs product decisions): macOS arch decision (manifest is all x64), deployment target ambiguity (matrix 12.1 env vs CMake flag 11 — the CMake flag wins, effective = 11), IFW upgrade, windows-2025.
Test plan: PR checks (PAT target; IFW step skipped on PRs) + manual
Run workflowon this branch = full package on 3 OSes with hash check and artifact upload.Rollback: revert.
Duck review: scope right (integrity control only). Addressed: added
permissions: contents: read(dispatch exposure). Hash provenance: both digests match Qt's published.sha256files alongside the 4.3.0 archive downloads (and my own hash of the download). Fail-closed: relies onshell: bash-eo pipefail default (not separately tested). Gate: dispatch full-package run must be green on macOS+Windows (see PR comments).