Repository navigation
test: Electron startup smoke test in CI (prerequisite for #340) - #348
Merged
Merged
Conversation
…340 prerequisite) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
anchapin
force-pushed
the
deps/340-electron-smoke-test
branch
from
October 14, 2026 21:02
8f7c71e to
d51d0be
Compare
This was referenced Oct 14, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #340 (does not close it; see the decision comment there — the Electron bump itself is deferred).
Changes
app/background.js: withPAT_SMOKE_TEST=1, exits 0 once the AngularJS app has bootstrapped (5s afterdid-finish-load), exits 1 ondid-fail-load,render-process-gone, bootstrap failure or 90s timeout. No behavior change without the env var.build_pat.yaml: new step after the CMake build on all 3 OSes runsnpx electron build(xvfb +--no-sandboxon Linux).Verified: locally on Apple Silicon (Node 24):
PAT_SMOKE_TEST=1 npx electron build-> 'PAT smoke test passed', exit 0. CI result in checks.Limits: runs the built bundle in the repo's Electron, not the packaged installer layout; does not exercise project open, server, analysis or webviews.
Rollback: revert.
CI: smoke step green on Ubuntu, macOS, Windows ("PAT smoke test passed" in logs). Duck review: worth it as a startup/bootstrap check only (not installer or usability validation; no project/server coverage). Addressed: step-level
timeout-minutes: 3hard timeout. Not done: isolated CI userData path / smoke-mode UI suppression.