Repository navigation
feat: NethVoice chat - #229
Open
edospadoni wants to merge 50 commits into
Open
edospadoni wants to merge 50 commits into
edospadoni wants to merge 50 commits into
Conversation
edospadoni
force-pushed
the
nethvoice-chat
branch
from
October 6, 2026 08:03
a54c07f to
3476797
Compare
edospadoni
marked this pull request as ready for review
October 6, 2026 08:10
tonyco97
reviewed
Oct 6, 2026
tonyco97
left a comment
tonyco97
left a comment
Collaborator
There was a problem hiding this comment.
Review notes inline. Verified on the code: the healthz probe that can outlive the effect (and re-enable the chat after the permission is revoked), the double OS notification, and Ctrl/Cmd+Enter falling back to a call. I'd fix those three before merging. The others are marked as not reproduced.
…et", no leave on CTI groups, as in the CTI
After a drag the dock's corner is kept and the island opens away from it; a click on a head does not move the window.
edospadoni
force-pushed
the
nethvoice-chat
branch
from
October 15, 2026 14:25
c8aaa12 to
1705200
Compare
… (a native one fell behind the screen-saver level window)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chat island in its own always-on-top window, like the phone island.
nethlink://chat?to=<user>opens a conversation: with NethLink running the CTI opens its chats here and keeps its Messages list./chat-gw/healthz) and the profile has the Chat permission.Refs: nethesis/ns8-nethvoice#992, nethesis/nethvoice-cti#577
Part of NethServer/dev#7648 (NethVoice chat).