Repository navigation
feat(calls): video call action for operators with a video device - #240
Open
edospadoni wants to merge 1 commit into
Open
edospadoni wants to merge 1 commit into
edospadoni wants to merge 1 commit into
Conversation
Add a video option to the call path (renderer hook, IPC, Phone Island page) that starts the call with the camera in the first INVITE through phone-island-call-start with video: true, and a video call icon next to the call icon for operators that have a device able to receive video (WebRTC, NethLink, mobile app or a known desk video phone). Desk phones refuse a video upgrade added later in the call.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desk video phones such as the Yealink T58W accept video only when it is offered in the first INVITE, so the camera has to be on from the start of the call. Phone Island supports it with
video: trueonphone-island-call-start(nethesis/phone-island#295).callNumber(number, { video: true })carries the flag throughEMIT_START_CALL→PhoneIslandController.call→START_CALL→phone-island-call-start.isVideoCapableExtensionin shared utils).Requires the Phone Island release that includes nethesis/phone-island#295; with older versions the option is ignored and the call starts audio only.
NethServer/dev#8243