Repository navigation
feat(python3-nethsec): move library and its tests into this repo - #1826
Merged
Merged
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
nethsecurity-api code is now inside this repo
Build the nethsec wheel from local source instead of fetching it from the old external repo, and bring its tests, test image, docs, and scans in as GitHub Actions scoped to this package. Assisted-by: Claude Code:claude-opus-4-8[1m]
The tests could not pull the published test image (private and not tagged for the branch), so build it locally when it is missing instead. Assisted-by: Claude Code:claude-opus-4-8[1m]
Generate the python3-nethsec API reference inside the existing documentation build and drop the separate workflow. Assisted-by: Claude Code:claude-opus-4-8[1m]
Building the site now needs a Ruby container (host Ruby 4.x cannot build the pinned gems) and a pydoctor step for the python3-nethsec API docs. Assisted-by: Claude Code:claude-opus-4-8[1m]
gsanchietti
force-pushed
the
integrate-python3-nethsec
branch
from
August 3, 2026 08:20
f0a997a to
ba620a6
Compare
gsanchietti
marked this pull request as ready for review
August 3, 2026 08:20
setup.py hardcoded its own version, duplicating PKG_VERSION in the Makefile and requiring both to stay in sync. Read it from an env var injected by the OpenWrt build instead. Assisted-by: Claude Code:claude-sonnet-5
gsanchietti
force-pushed
the
integrate-python3-nethsec
branch
from
August 3, 2026 11:06
27bb8a4 to
f526b79
Compare
Tbaile
approved these changes
Aug 3, 2026
Tbaile
left a comment
Tbaile
left a comment
Collaborator
There was a problem hiding this comment.
I'd take the chance to remove the image upload and make the build re-create it every time, we lose a troublesome side that is not fully used at the moment
The test image published to ghcr.io was unused: the tests workflow builds it locally. Remove the publish workflow and builder/build.sh, and rebuild the image from the Containerfile on every test.sh run so a changed Containerfile is never shadowed by a stale local image. Assisted-by: Claude Code:claude-opus-5[1m]
gsanchietti
force-pushed
the
integrate-python3-nethsec
branch
from
August 3, 2026 13:04
f526b79 to
1050ed8
Compare
Member
Author
I agree: removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the
nethsecPython library (previously the externalNethServer/python3-nethsecrepo) fully into this repository.nethsecwheel now builds from local source underpackages/python3-nethsec/src— no more external fetch./apidocs/python3-nethsec/.Why
Keeps the library, its tests, and its checks in one place so changes here are tested and documented here.
Checks
python3-nethsec-tests— runs the test suite; builds the test image locally when missing (no registry dependency).python3-nethsec-test-image— builds and publishes the test image for reuse.python3-nethsec-scans— Trivy SBOM and report.Verified
nethsec-1.7.1-py3-none-any.whl.Notes for reviewers
MakefilePKG_VERSIONandsetup.pyversion(documented in the package README).