Repository navigation
fix(banip): update installation scripts and add feed rebuilding logic - #1922
Merged
Merged
Conversation
Tbaile
reviewed
Oct 7, 2026
Tbaile
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue introduced by the banIP upgrade to version 1.8.10, which caused enterprise feeds not to load correctly.
Changes:
97-nethsec-banip-feedsuci-default. Whenbanip.custom.feedsis still in the 1.0 format (rule_4) and banip 1.8 is installed, it rebuilds the file withts-ip.ns-threat_shieldpostinst, so the rebuilt feeds are loaded right away.20_threat_shieldcall from the postinst:default_postinstalready runs it before.97-nethsec-banip-insightsto98-nethsec-banip-insightsto avoid two uci-defaults with the same number.Closes: #1921