Fix the -e flag of moabb.run splitting its value into characters - #1179
Open
NotAFlightRisk wants to merge 1 commit into
Open
Fix the -e flag of moabb.run splitting its value into characters#1179NotAFlightRisk wants to merge 1 commit into
NotAFlightRisk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-e/--evaluationsis declaredtype=list, so argparse runslist()over the string you pass it.-e WithinSessionreachesbenchmark()as thirteen seperate letters and the run stops onKeyError: 'W', after it's already printed the paradigms it was about to work through. Every other value does the same, so there isn't a spelling of-ethat works.nargs="+"hands it the list of names the Python API already takes (benchmark(evaluations=["WithinSession"])). The help text went with it, since it was telling you to pass a list and had the options butted up against the "By default" sentence with no space. I've not putchoices=on the argument, so a name that isn't one of the three still gets as far asbenchmarkbefore it fails, same as today.Most of the diff is the new test file. There was nothing covering
run.pyat all, which is probaly how this sat there since #264 - CI calls the runner without-e.