Skip to content

Doc differences with deno compile --include #18

Description

@NfNitLoop

I should update the README w/ how this compares to the newly-added --include option in deno compile.
See: denoland/deno#26939
And: denoland/deno#20885

I want to do some testing to make sure I'm understand how it works before I document things, but as it stands, it looks like the new --include option has some weaknesses vs. deno-embedder:

  • Only works with deno compile not deno run jsr:…?
  • Works by hijacking the Deno.read*() functions to return embedded data instead of reading from the FS. (Doesn't this make reads ambiguous? Or is import.meta.dirname returning something like embedded:// so it's unambiguous?)
  • Requires granting --allow-read. (Avoiding that need is a big part of the purpose of deno-embedder. But I suppose this is moot since you're limited to deno compile anyway.)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions