Skip to content

ConfirmDialog and Drawer respect prefers-reduced-motion - #135

Merged
mgoldsborough merged 3 commits into
mainfrom
overlay-reduced-motion
Oct 31, 2026
Merged

mgoldsborough merged 3 commits into
mainfrom
overlay-reduced-motion

Conversation

@mgoldsborough

Copy link
Copy Markdown
Contributor

The scrim fade, the dialog's rise and the drawer's slide-in now drop under prefers-reduced-motion: reduce, matching what SidebarLayout already does for its drawer. The media rule follows the animated rules at equal specificity, so it wins.

  • Test: both stylesheets carry the reduced-motion rule for every animated class.
  • CHANGELOG: Unreleased → Fixed. Touches the same Unreleased heading as One lighter scrim for ConfirmDialog and Drawer #134; whichever merges second takes both entries.
  • npm run ci green; vendored IIFE unchanged.

@mgoldsborough

Copy link
Copy Markdown
Contributor Author

QA Review: PR #135

Scope: 4 files, +36/−0 · supplied review worktree; creation and dependency installation skipped · reviewed: 186f066 · CI: green
Round: 1
Risk: LOW
Why this exists: Respect reduced-motion preferences when opening confirmation dialogs and drawers.

Critical (must fix)

None.

Fix in-PR

None.

Suggestions

None.

What Looks Good

  • Additive CSS overrides cover both scrims, the confirmation panel, and all three drawer directions. Equal specificity and later placement make the overrides effective.
  • No API changes or animation-dependent lifecycle behavior affected.
  • The regression test checks the injected stylesheets, consistent with repository testing guidance.
  • Supplied required and additional CI checks all pass. No suite rerun or tree writes performed.

Body claims

  • ✅ Reduced-motion rules cover every entrance animation in both components and follow the existing SidebarLayout pattern.
  • ✅ Regression coverage and an Unreleased → Fixed changelog entry are present.
  • ✅ Vendored IIFE is unchanged in the diff; supplied Build check passes.
  • ✅ Supplied CI results support the verification claim; the author's local npm run ci invocation was not independently observed.
machine record
{
  "kind": "review",
  "pr": 135,
  "round": 1,
  "reviewed": "186f0667d66b5683f91a5b898740f006fc448151",
  "delta_base": null,
  "ci": "green",
  "risk": "LOW",
  "stop_gate": "n/a",
  "verdict": "Ready to merge; no findings.",
  "label": "eligible-on-green",
  "findings": []
}

@mgoldsborough mgoldsborough added the qa-reviewed QA review completed with no critical issues label Oct 31, 2026
@mgoldsborough

Copy link
Copy Markdown
Contributor Author

QA Review: PR #135

Scope: Delta: 11 files, +65/−25 · supplied review worktree; creation and dependency installation skipped · reviewed: 795d5b5 · CI: green
Round: 2 (delta base: 186f066)
Stop gate: SHIP THE CORE
Risk: LOW

Critical (must fix)

None.

Fix in-PR

None.

Suggestions

None.

What Looks Good

  • The delta merges main's gutter customization and version changes. Defaults remain intact, exports have regression coverage, and package/client versions agree.
  • The reduced-motion overrides and regression test remain intact after the merge.
  • Round 1 had no findings requiring fix verification. The full-branch severity-floor scan found no data-loss, security, or authorization concerns.
  • All supplied required and additional CI checks pass. No suite rerun or tree writes performed.

Body claims

Not re-audited in round 2, per delta-review scope.

machine record
{
  "kind": "review",
  "pr": 135,
  "round": 2,
  "reviewed": "795d5b55b6b429ff3d8e42cb19559e9817751b1b",
  "delta_base": "186f0667d66b5683f91a5b898740f006fc448151",
  "ci": "green",
  "risk": "LOW",
  "stop_gate": "ship-the-core",
  "verdict": "SHIP THE CORE — no findings.",
  "label": "eligible-on-green",
  "findings": []
}

# Conflicts:
#	CHANGELOG.md
#	src/__tests__/ui/confirm-dialog.test.tsx
@mgoldsborough

Copy link
Copy Markdown
Contributor Author

QA Review: PR #135

Scope: Delta: 5 files, +45/−4 · supplied review worktree; creation and dependency installation skipped · reviewed: ff5a10a · CI: green
Round: 3 (delta base: 795d5b5)
Stop gate: SHIP THE CORE
Risk: LOW

Critical (must fix)

None.

Fix in-PR

None.

Suggestions

None.

What Looks Good

  • The delta incorporates main's shared, lighter scrim constant and regression coverage. Both components consume the same CSS literal without changing overlay behavior or public contracts.
  • The reduced-motion overrides and their regression coverage remain intact after the merge.
  • Round 2 had no findings requiring fix verification. The full-branch severity-floor scan found no data-loss, security, or authorization concerns.
  • All supplied required and additional CI checks pass. No suite rerun or tree writes performed.

Body claims

Not re-audited in round 3, per delta-review scope.

machine record
{
  "kind": "review",
  "pr": 135,
  "round": 3,
  "reviewed": "ff5a10a7ad99939c49c3f4267504404a42a4cd3b",
  "delta_base": "795d5b55b6b429ff3d8e42cb19559e9817751b1b",
  "ci": "green",
  "risk": "LOW",
  "stop_gate": "ship-the-core",
  "verdict": "SHIP THE CORE — no findings.",
  "label": "eligible-on-green",
  "findings": []
}

@mgoldsborough
mgoldsborough merged commit 65caf5c into main Oct 31, 2026
8 checks passed
@mgoldsborough
mgoldsborough deleted the overlay-reduced-motion branch October 31, 2026 17:43
mgoldsborough added a commit that referenced this pull request Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qa-reviewed QA review completed with no critical issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant