[#312] Add --follow-symlinks flag - #455
Merged
Merged
Conversation
dyegoaurelio
approved these changes
Sep 1, 2026
jfly
approved these changes
Sep 2, 2026
jfly
left a comment
jfly
left a comment
Collaborator
There was a problem hiding this comment.
A couple comments for you, but LGTM. Thanks!
Formatting a symlink replaces it with a regular file. That stays the default and is now warned about, --follow-symlinks formats the file the link points at instead. Fixes #312 Co-authored-by: Jeremy Fleischman <me@jfly.fyi> Co-authored-by: Matt Sturgeon <matt@sturgeon.me.uk>
MattSturgeon
force-pushed
the
sereja313/add-follow-symlink
branch
from
September 10, 2026 19:14
e41264f to
608248d
Compare
MattSturgeon
approved these changes
Sep 10, 2026
MattSturgeon
left a comment
MattSturgeon
left a comment
Contributor
There was a problem hiding this comment.
I iterated on @jfly's README suggestion and replaced the CHANGELOG entry with a conventional commit (that Knope will pick up on).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formatting a symlink replaces it with a regular file. That stays the default and is now warned about,
--follow-symlinksformats the file the link points at instead.