Repository navigation
fix(plugin): clear the detekt and ktlint errors failing preMerge - #903
Merged
kdroidFilter merged 1 commit intoNov 2, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
preMergehas been red onnucleus-3.0since the Flathub work landed, which fails thegradlejob on every PR and skips the jobs behind it (test-packaging,test-graalvm,tao-headful,tao-a11y). This fixes the three lint errors. Behaviour doesn't change.Minimal reproduction
Setup:
nucleus-3.0at d975bba, Ubuntu locally, and thegradlejob of that commit's run on GitHub (run 41461175754).Actual result:
Root cause and fix
FlathubRepository: the URL list kept nullable values through afilter, so it needed!!afterwards.mapNotNulldrops the nulls and keeps the type non-null.AbstractGenerateFlathubRepositoryTask: usesLocale.ROOT, like the other%02xdigests in the plugin.examples/lab/app/build.gradle.kts: splits the screenshot base URL across two lines. The resulting string is the same.Testing
On Ubuntu Linux:
./gradlew preMerge --continuefails with the three errors above before this change and passes after it.Not tested: Flathub generation end to end, and macOS or Windows. Nothing here is platform-specific.
Checklist
nucleus-3.0./gradlew preMergepassesapiDumpcommitted if the API changed🤖 Generated with Claude Code