Release hyrax-1.18.0, libdap-3.22.0#372
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe changes document the libdap4 3.22.0 release, update package and ABI metadata, expand the development history, and revise Travis CI’s environment, staging, and scan workflow. No functional library code or public declarations changed. ChangesRelease and version updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ChangeLog`:
- Around line 7-11: Proofread and correct the identified typos and transcription
errors throughout the ChangeLog, including “coverge,” “tempate,” “don't we that
OS,” “earn parsing,” “varaible,” “si,” “one persons,” “dmr tess,” “needsto,”
“Retred,” “Mionr,” and “chnages,” while preserving the original release-history
content and formatting.
In `@NEWS`:
- Around line 6-14: Update the Version 3.22.0 entry in NEWS to include the
release build number alongside the version, using the format expected by
configure.ac within the first 15 lines. Preserve the existing release notes and
determine the correct build number from the project’s release metadata.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: e92c0043-9bdb-41fe-99b0-5a5eb0c7845c
📒 Files selected for processing (3)
ChangeLogNEWStravis/travis_libdap_build_offset.sh
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.travis.yml:
- Around line 82-86: Remove the obsolete commented-out SDKMAN setup block,
including the commands that install and select Java 21 and print its version.
Keep the adjacent Java 17 provisioning comments unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: f737820e-d162-4399-99bd-6c76bf8d620f
📒 Files selected for processing (1)
.travis.yml
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.travis.yml (1)
13-13: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winUpdate the gcovr rationale for Jammy
README.coverage.mdand the Travis comment still refer to Ubuntu Focal / gcovr 4.x, but this CI now uses Jammy, whose repo package is gcovr 5.0. Refresh the wording to match the current distro while keeping the 8.2 pin explanation.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.travis.yml at line 13, Update the Jammy-related comments in the Travis configuration and README.coverage.md to reference Ubuntu Jammy and its repository-provided gcovr 5.0 instead of Focal and gcovr 4.x, while preserving the explanation for pinning gcovr 8.2.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.travis.yml:
- Around line 125-131: Update the Travis CI job definitions for make, asan, and
distcheck to use stage: build instead of stage: never, while leaving the
never-stage configuration unchanged unless required. Ensure these validation
jobs run on normal branches.
- Around line 81-89: Move the JAVA_HOME and PATH exports from the before_install
conditional into the scan job’s script phase or env configuration so they are
available when java -version and sonar-scanner run. Keep the Java 21
installation in before_install and preserve the scan-job-only scope.
---
Outside diff comments:
In @.travis.yml:
- Line 13: Update the Jammy-related comments in the Travis configuration and
README.coverage.md to reference Ubuntu Jammy and its repository-provided gcovr
5.0 instead of Focal and gcovr 4.x, while preserving the explanation for pinning
gcovr 8.2.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: ef67ab94-afc2-4885-b159-2a8cec27041a
📒 Files selected for processing (1)
.travis.yml
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.coverage.md`:
- Line 56: Update the gcovr-related comments in the Travis configuration
sections corresponding to the package setup and scan command so they
consistently describe Ubuntu Jammy’s default gcovr 5.x behavior, replacing
obsolete references to Focal’s 4.2 package. Keep the configuration commands
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: e83f84d8-9783-4a7d-9f1b-a57c697ddcda
📒 Files selected for processing (3)
.travis.ymlREADME.coverage.mdtravis/travis_libdap_build_offset.sh
…d offset for master/main builds.
|
3 participants
PR for new release
Description
@jgallagher59701 - This is ready for review. Please note that we used an LLM to look at the commit log and determine the API/ABI version number for this release. YMMV
Tasks
gitlog-to-changelogconfigure.ac,INSTALL, )configure.ac)