fix: surface failed compose service scan information - #161
Merged
Conversation
github-actions
Bot
added
core
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
==========================================
+ Coverage 78.95% 79.88% +0.92%
==========================================
Files 26 32 +6
Lines 4158 4986 +828
==========================================
+ Hits 3283 3983 +700
- Misses 875 1003 +128
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
advaitpatel
approved these changes
Aug 20, 2026
advaitpatel
left a comment
advaitpatel
left a comment
Collaborator
There was a problem hiding this comment.
looks good to me. thank you for your contributions
myukitty
added a commit
to myukitty/DockSec
that referenced
this pull request
Aug 21, 2026
OWASP#161 records failed services in the compose results dict, but nothing reads them back out. A run where some services could not be scanned still prints a summary and a score as if every service had been covered, which is the visibility gap OWASP#131 describes. Add the missing user-facing half: - carry total_services next to failed_services so the summary has a denominator, and - print "N of M services could not be scanned: <names>" in the Quick take block, and include failed_services/total_services in --json. run_full_scan records a service twice when both its Dockerfile and its image scan fail, so the names are de-duplicated before counting. Fixes OWASP#131. Builds on OWASP#161.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves compose scan visibility by tracking failed service scans and returning failed service details in the compose scan results.
Changes
failed_servicestracking inComposeOrchestrator.run_full_scan.failed_servicesin the returned results dictionary.failed_servicesis empty for successful offline scans.Testing
python -m py_compile docksec/compose_scanner.pypython -m pytest tests/test_compose_scanner.py -v