Skip to content

Fix swallowed exception in GetJson - #915

Closed
Obito-001 wants to merge 1 commit into
OWASP:devfrom
Obito-001:dev#510
Closed

Fix swallowed exception in GetJson#915
Obito-001 wants to merge 1 commit into
OWASP:devfrom
Obito-001:dev#510

Conversation

@Obito-001

@Obito-001 Obito-001 commented Aug 28, 2026

Copy link
Copy Markdown

Fixes issue #510 by preventing unrecoverable exceptions in GetJson from being silently ignored.

Changes:

  • Replace the swallowed exception with a RuntimeException.
  • Preserve the original exception as the cause.
  • Add a regression test for BufferedReader failures.

Testing:

  • GetJsonTest: 7 tests passed
  • Spotless formatting check: passed

@SeanDuggan
SeanDuggan self-requested a review September 18, 2026 15:07
@SeanDuggan SeanDuggan self-assigned this Sep 18, 2026
@SeanDuggan

SeanDuggan commented Sep 18, 2026

Copy link
Copy Markdown
Member

It does not close #915

@SeanDuggan SeanDuggan closed this Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SeanDuggan SeanDuggan Awaiting requested review from SeanDuggan

Assignees

@SeanDuggan SeanDuggan

Labels

None yet

Projects

Security Shepherd
Status: Backlog

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Obito-001 @SeanDuggan