Repository navigation
Minor language corrections - #159
Conversation
📝 WalkthroughWalkthroughUpdated Polish localization wording for time preference labels, trip planner actions, and turn-by-turn directions. ChangesPolish localization
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@OTPKit/Sources/OTPKit/Resources/pl.lproj/Localizable.strings`:
- Line 127: Update the localized value for trip_planner.find_routes to
explicitly mention the route object, using the concise Polish label “Znajdź
trasę” while leaving the key unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 356d99cd-cc50-41ff-99ba-b336707e065c
📒 Files selected for processing (1)
OTPKit/Sources/OTPKit/Resources/pl.lproj/Localizable.strings
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
aaronbrethorst
left a comment
There was a problem hiding this comment.
Thank you for this — translation corrections from someone who actually speaks the language are worth a lot more than anything I could produce, and "fits on the screen" is a real constraint that's easy to miss when writing the English strings.
I checked the mechanical invariants rather than second-guessing your Polish: the diff is values-only across all 6 changes, key parity with en.lproj still holds at 239 keys, the file still lints as a valid .strings plist, and leg.step_turn keeps %1$@/%2$@/%3$@ in the same positions and types. That last one matters because it's formatted in RelativeDirection.swift as (direction, street, distance), and na reads better than w there — the old version produced the doubled "Skręć w lewo w Pine St."
Approving. Merging once CI has run — this PR is from a fork so its build and lint never got approval to start, and main is separately red on a flaky rental test right now. Neither is anything to do with your change.
Edited few language strings - both to make end-users understand the meaning better and also to fit into the screen size.
Summary by CodeRabbit