feat: isolate hardware factory and test APIs - #882
Draft
wabicai wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
@onekeyfe/hd-test-apias the separately publishable package for factory and automated hardware-test methodsdeviceReadSEPublicCertanddeviceSESignMessageinCoreApifor the production verification flowWhy
Factory and automated-test workflows need access to private hardware commands without exposing those commands through the production HD Core surface or shipping their protobuf definitions in the production schema.
Impact
deviceVerify@onekeyfe/hd-test-apiChecks
@onekeyfe/hd-transport,@onekeyfe/hd-core,@onekeyfe/hd-common-connect-sdk, and@onekeyfe/hd-test-apiin dependency ordertsc --noEmit -p packages/hd-test-api/tsconfig.jsonyarn check-versionspassed for all 31 packagesgit diff --checkpassedNo physical hardware write, erase, provisioning, or firmware operation was executed.
Known draft state
factory/apiadvanced after this worktree was created and GitHub currently reports a mergeconflict. The new base includes
DeviceFactoryPermanentLock; syncing it requires an explicitfollow-up migration of that newly added factory API into this package and revalidation against the
latest protobuf schema.