fix: require Pro bootloader 2.8.0 before MCU updates - #904
Draft
wabicai wants to merge 2 commits into
Draft
Conversation
wabicai
marked this pull request as draft
August 30, 2026 07:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
checkNeedUpdateBootForTouchreportshouldUpdatefor OneKey Pro whenever the current bootloader is older than 2.8.0, even if firmware is below 4.1.0 or the device is already in bootloader mode.Intent and context
Installing current Pro MCU packages (4.14.0 / 4.18.0 / 4.21.0 from
firmware-v8) on bootloaders older than 2.8.0 fails inload_image_headerwithUpdate file header invalid. Boot 2.8.0 expanded the MCU size limit from 3.67MB to 5.5MB. App already updates boot before firmware whencheckBootloaderReleasesays so; the helper previously required firmware >= 4.1.0 and therefore skipped boot on empty/recovery devices.Root cause
checkNeedUpdateBootForTouchgated Pro boot updates on firmware >= 4.1.0 (ResourceUpdateavailability). That is the wrong predicate for MCU header compatibility. The real line is bootloader < 2.8.0.Design decisions
firmwareUpdateV2/firmwareUpdateV3install flows unchanged. Hosts still update boot, then MCU.boot < 2.8.0always returnsshouldUpdate: true.PRO_MCU_MIN_BOOTLOADER_VERSION(2.8.0) withMIN_UPDATE_V3_BOOTLOADER_VERSION.Compatibility and risk
checkBootloaderReleasepayload is the same; more Pro devices now reportshouldUpdate.startUpdateWorkflowalready does boot-then-firmware whenbootloader.hasUpgradeis true.firmwareUpdateV2.Hardware coverage
Unit-tested only. Not verified on a physical Pro with boot < 2.8.0.
Test plan
yarn --cwd packages/core test --runInBand check-need-update-boot-for-touchyarn agent:check --profile commitcheckBootloaderReleaseshould report shouldUpdate