chore(ci): fix broken release-please workflow - #177
Merged
Conversation
The `version` job was removed in c9406d8, but publish-snapshot, build-context-snapshot and docker-snapshot still referenced it via `needs: version`. GitHub rejected the entire workflow file, so every run since then failed after 0s and release-please stopped producing release PRs. Drop the three snapshot jobs to align with the OneLiteFeather release-please standard: releases only, no -SNAPSHOT intermediate versions on main. Also remove the package-level `release-type: "java"` so the top-level `"simple"` applies — "java" drives the Maven-style SNAPSHOT bump that produced `chore(main): release 2.4.2-SNAPSHOT`, which a Gradle project using the x-release-please-version marker does not need. Realign the marker in build.gradle.kts with .release-please-manifest.json (2.4.1). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Test results 42 files 42 suites 5s ⏱️ Results for commit 302e920. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Commit c9406d8 (
chore(ci): remove version step) removed theversionjob, but three jobs kept referencing it vianeeds: version/needs.version.outputs.*:publish-snapshotbuild-context-snapshotdocker-snapshotGitHub rejects the entire workflow file when
needspoints at an unknown job. Every run since 2026-08-22 failed after 0s with "This run likely failed because of a workflow file issue", so release-please never executed — which is whyfeat: add project entity usage (#176)produced no release PR.Side note: the removed job read
^version=fromgradle.properties, where noversionkey exists (onlygroup). It was already returning an empty string before it was deleted.Changes
.github/workflows/release-please.ymlpublish-snapshot,build-context-snapshot,docker-snapshot(-39 lines)release-please-config.json"release-type": "java"so top-level"simple"appliesbuild.gradle.kts2.4.2-SNAPSHOT→2.4.1to match the manifestrelease-type: "java"drives the Maven-style SNAPSHOT bump that producedchore(main): release 2.4.2-SNAPSHOT (#150). A Gradle project using thex-release-please-versionmarker inbuild.gradle.ktsdoesn't need it — that's the OneLiteFeather standard ("simple"+ a singleextra-filesentry).Remaining jobs:
release-please→publish,build-context→docker,sbom. Theworkflow_dispatchpath for manually rebuilding a Docker image is untouched.Verification
needsgraph resolves — no references to non-existent jobs, noneeds.versionleftovers anywhere in.github/workflows/.release-please release-pr --dry-runagainst this repo: findsv2.4.1at86f33e8, considers 56 commits, and would openchore(main): release 2.5.0— the correct minor bump for thefeat:commit, no reset. Updaters:CHANGELOG.md,build.gradle.kts(Generic, via the marker),.release-please-manifest.json.Caveat: the dry run reads config and manifest from remote
main, so it validates the version calculation and updater set but not the localrelease-typechange. That effect (no more SNAPSHOT follow-up PRs after a release) only becomes observable after merge.Note
This PR is titled
chore(ci):so it doesn't itself trigger a version bump.🤖 Generated with Claude Code