chore(ci): adopt the central Renovate preset - #146
Merged
Conversation
The config here predates the org standard: it extends `config:base` directly, disables semantic commits, and hand-rolls a label, a rebase strategy and a patch-automerge packageRule. The central preset already provides all of that -- config:recommended as its base, patch automerge, semantic commit messages, a `renovate` label, Europe/Berlin timezone, office-hours scheduling and vulnerability alerts -- so the local copies are redundant rather than additive, and they drift as the preset evolves. `:semanticCommitsDisabled` was actively harmful here: release-please parses Conventional Commits to decide the version bump and to build the changelog, so every Renovate merge landed without a type and produced neither. The `:default(...)` argument names the team the preset assigns as reviewer on each PR. `vulpes-maintainer` is the slug that actually exists in the org (singular, unlike most `*-maintainers` teams), and is what Vulpes-Backend already uses. The patch-automerge packageRule is dropped rather than carried over, since the preset covers it. Vulpes-Backend still has that leftover.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Split out of #143 so the Renovate migration lands on its own.
renovate.jsonhere predates the org standard — it extendsconfig:basedirectly and hand-rolls what the central preset already provides:{ "extends": ["config:base", ":semanticCommitsDisabled"], "rebaseWhen": "conflicted", "labels": ["Renovate"], "packageRules": [{ "matchUpdateTypes": ["patch"], "automerge": true }] }The central preset brings
config:recommendedas its base, plus patch automerge, semantic commit messages, arenovatelabel,Europe/Berlintimezone, office-hours scheduling (schedule:officeHours+schedule:automergeOfficeHours) and vulnerability alerts. The local copies are therefore redundant rather than additive, and they drift as the preset evolves.:semanticCommitsDisabledwas actively harmful here. Release Please parses Conventional Commits to decide the version bump and to build the changelog, so every Renovate merge landed without a type and produced neither. That matches whatmain's history looks like —Update dependency net.onelitefeather:mycelium-bom to v1.8.2 (#136),Update Gradle to v9.7.1 (#134)and so on, none of which Release Please can classify.Two notes on the details
The team argument.
:default(...)names the team the preset assigns as reviewer on every Renovate PR — without it, PRs get no reviewer. The org convention is<team>-maintainers, but the slug that actually exists for Vulpes isvulpes-maintainer(singular). Verified againstorgs/OneLiteFeatherNET/teams; it's also what Vulpes-Backend already uses.The patch-automerge rule is dropped, not carried over, because the preset covers it. ℹ️ Vulpes-Backend still carries that leftover
packageRulesblock — worth cleaning up there separately.Types of changes
CI configuration only — none of the categories above fit precisely; no application code is touched.
Checklist
No tests: this is a Renovate config file, validated by JSON parse and by the preset reference matching the org's canonical form. Its real effect only shows on Renovate's next run against
main.Further comments
Branched directly off
main, so this is independent of #143 and the two can merge in either order.