Override resourcePath instead of infoDictionary in NSBundle, MyOpenGLView code simplification - #722
Merged
Merged
Conversation
…te other things like locales in future) Remove unneeded Linux hack
mcarans
requested review from
AnotherCommander,
Kaks,
KonstantinosSykas,
dsalt,
ericwalch,
jobi-wan,
kanthoney,
mwerle,
oocube and
phkb
as code owners
August 22, 2026 02:08
|
No problems noticed at buildtime or during play with 722.patch . |
Contributor
Author
|
@phkb If this works for you, I'll merge and turn further_simplify branch into a PR. BTW, I've asked about the Windows WS_POPUP hack here as it would be nice to be able to avoid the Windows API code if possible: In other news since our BB has been down for 3 days (should we be looking for an alternative such as GitHub Discussions which I just realised is already set up - https://github.com/OoliteProject/oolite/discussions/ - or Discord?), I'll share here that I missed that MSYS2 have deprecated MINGW64 in March (in favour of UCRT64): https://www.msys2.org/news/#2026-03-15-deprecating-the-mingw64-environment. Therefore, I'm considering removing the Windows gcc builds which are on MINGW64. EDIT: I've now made even_further_simplify branch based on further_simplify. (I try to do Windows Oolite dev in the weekend.) If this PR works for you and even_further_simplify works too, I can skip the PR for further_simplify cc @LW-archlinux |
Contributor
|
Whenever I pull #PR722 git GitHub Desktop, I get this message: 
Not sure which direction to take here. Suggestions? |
Contributor
|
Going to try resetting my source tree. Standby |
Contributor
|
Yeah, that fixed it. Testing underway |
phkb
approved these changes
Aug 22, 2026
Github discussion can be useful if you want to reduce the number of on issues and prefer discussion before starting a PR but is not suitable as a replacement for oolite forum. The first task should be to get a backup of the forum content. Try to contact the people that rescued the old forum when aegidian.org domain was lost. |
Contributor
|
Timer is working on the BB issue. I'm in communication with him. When I have more info I'll post updates, probably on Discord, but I could also post to the discussions here. |
|
Either my test was not thorough enough or this PR was changed after my test. Anyway 4472873 fails hard . run_oolite.sh outputs nothing to terminal, Latest.log shows : |
Contributor
Author
Hmm. There was no change in the PR after your check. The failure looks related to one of the main features of the PR ie. overriding resourcePath instead of infoDictionary in NSBundle. It looks like it didn't work looking in share folder - I will check cc @phkb |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #713
Further simple simplification
Removal of Linux hack that doesn't seem to be needed
Worked ok for me on Windows and Linux
@LW-archlinux, @phkb please can you test
Also if this PR works for you, can you try this branch which builds on top of the changes in this PR (and makes some really nice simplifications): https://github.com/mcarans/oolite/tree/further_simplify ?