Even further simplify

[mcarans]

#725 +
move setUpBasicOpenGLStateWithSize from GameController.m to MyOpenGLVIew.m
make common updateGLSize function called by resize and initialiseGLwithSize
Move the related methods to be next to each other in the source for readability

@phkb @LW-archlinux If this works then I won't need to merge 725

[mcarans]

@phkb in addition can you try what's suggested here? https://discourse.libsdl.org/t/how-to-go-fullscreen-in-sdl3-without-ws-popup/69148/4 (ie. remove the Windows hack and instead hide the SDL window, call SDL_SetWindowFullscreen and show the window) then see if you get the 5 second delay when switching between window and fullscreen. Funnily enough this is the trick required to centre the game window after splash on Wayland on Linux.

SDL_HideWindow(window);
SDL_SetWindowFullscreen(window, fullScreen);
SDL_ShowWindow(window);

[mcarans]

Setting to draft while I investigate failure on master

[phkb]

The code in the PR is fine, tested OK, no pauses. However, attempting to remove the hack and do the hide/setWindowFullScreen/show thing still caused delays.

[mcarans]

The code in the PR is fine, tested OK, no pauses. However, attempting to remove the hack and do the hide/setWindowFullScreen/show thing still caused delays.

Thanks for testing. I have reported that hide/show didn't work: https://discourse.libsdl.org/t/how-to-go-fullscreen-in-sdl3-without-ws-popup/69148/5

I will have to rebase this PR assuming the fix I've made helps resolve Linux startup issues (#727)

[mcarans]

@phkb @LW-archlinux I have rebased this with the fix (the revert) merged into master. Please let me know if it works for you.

[mcarans]

@oocube I saw you're commenting again. Please can you check this PR works for you. If this works then I won't need to merge 725.

The flatpak failure is that the archive.mesa3d.org site used by a dependency that FlatHub demanded is temporarily down so please ignore for now. Flatpak build working now