fix(windows): keep SDR matrix through HDR output transition - #1045
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A live Windows HEVC/P010 session decoded about 60 FPS for 40 seconds, then Media Foundation switched its output transfer to SDR and primaries to BT.709 while leaving
MF_MT_YUV_MATRIXabsent. OpenNOW inherited the original HDR BT.2020 matrix, rejected the mixed format, and restarted the decoder every ~250 ms, leaving black video and an apparent 4 FPS. A diagnostic-only first push confirmednegotiated=Pq/Bt2020/Bt2020 decoded=Sdr/Bt709/Bt2020 explicit=true/true/falseon the affected machine.When output explicitly becomes SDR/BT.709 and omits its matrix, choose the BT.709 matrix rather than carrying the original HDR one. Explicit contradictory matrix values still fail validation, and PQ/HLG transitions retain their BT.2020 requirements. This matches Media Foundation’s documented treatment of the unknown matrix as BT.709. A Windows-only regression test covers absent and unknown matrix values and the contradictory explicit case. Color-only values are retained in failure diagnostics without logging session data.
Full streamer workspace tests, strict Clippy, formatting and diff checks passed locally. Windows CI and a repeat live HDR session on the affected PC are pending before the draft is ready.