Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Closing this draft: the requested fix is the missing feedback pipeline, not lowering the configured bitrate ceiling. The separate cap is out of scope. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The official client limits its requested stream bitrate to 100 Mbps, but OpenNOW exposed and could announce 200 Mbps. Clamp persisted settings on load and save, cap the RTSP ANNOUNCE input to 100, and make desktop, console, onboarding, and quick-settings controls agree. Existing settings retain their JSON shape; an old saved 200 becomes 100 while unrelated values survive.
Focused core settings and RTSP tests, localization validation, formatting, and diff checks pass. This corrects a misleading limit, but does not explain a 3.8 Mbps live sample at a 100 Mbps setting. Qt 6 is unavailable on the local machine, so platform CI and a visual check of the changed controls are still required.