Skip to content

fix(stream): cap requested bitrate at 100 Mbps - #1046

Closed
zortos293 wants to merge 1 commit into
devfrom
capy/cap-requested-bitrate-at
Closed

zortos293 wants to merge 1 commit into
devfrom
capy/cap-requested-bitrate-at

Conversation

@zortos293

Copy link
Copy Markdown
Collaborator

The official client limits its requested stream bitrate to 100 Mbps, but OpenNOW exposed and could announce 200 Mbps. Clamp persisted settings on load and save, cap the RTSP ANNOUNCE input to 100, and make desktop, console, onboarding, and quick-settings controls agree. Existing settings retain their JSON shape; an old saved 200 becomes 100 while unrelated values survive.

Focused core settings and RTSP tests, localization validation, formatting, and diff checks pass. This corrects a misleading limit, but does not explain a 3.8 Mbps live sample at a 100 Mbps setting. Qt 6 is unavailable on the local machine, so platform CI and a visual check of the changed controls are still required.

Open in Capy

@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@capy-ai

capy-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Closing this draft: the requested fix is the missing feedback pipeline, not lowering the configured bitrate ceiling. The separate cap is out of scope.

@capy-ai capy-ai Bot closed this Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant