fix(streamer): report measured bandwidth and frame receive feedback - #1047
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
zortos293
marked this pull request as ready for review
September 24, 2026 17:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The receiver had packet arrival times and RTP timestamps, but QoS v7 sent zero bandwidth, delay, utilization, jitter, and clock fields. Track authenticated video packet trains in bounded receive state, exclude retransmissions and parity bytes, smooth frame receive capacity and utilization after the 100-frame warmup, and serialize the measured values in the 52-byte report. Periodic control diagnostics now include the reported estimate so a real stream can be checked against actual delivered bitrate.
Frame ACK v9 now uses the first authenticated packet's receive time for the matching assembled and admitted frame. It marks unmeasured float stages as unknown instead of zero, clears unsupported ECN claims, and removes a frame-time write that overlapped two fields. Preserve the user's bitrate ceiling in ANNOUNCE rather than lowering it to a DESCRIBE default; the 200 Mbps setting and UI remain unchanged.
Tests:
cargo test --manifest-path native/opennow-streamer/Cargo.toml --workspaceand strict workspace Clippy pass, including deterministic packet-train, RTP wrap, loss, parity and ACK timing tests. The QoS field meanings at several offsets follow client-side binary analysis but server response is still inferred; Windows CI and a same-scene live bitrate comparison are required before claiming the image-quality symptom is resolved.