fix(hdr): send active Windows display metadata for native HDR - #1048
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
zortos293
marked this pull request as ready for review
September 24, 2026 17:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read the current Windows HDR output via DXGI and carry its measured minimum, peak, full-frame luminance, primaries, and white point through Qt’s transient runtime capability to CloudMatch. Match the window’s monitor, refresh on output changes, and omit incomplete metadata rather than treating SDR or stale values as calibration. An HDR-capable swapchain remains usable when measurements are missing.
Validate the optional monitor fields in the Rust core and serialize them in the official request units. Pair-only Wayland snapshots and the existing requested-content fallback remain unchanged. SDR still sends
displayData:null; native HDR keeps the separate AI TrueHDR filter disabled. Document which mapping is inferred from the official client’s implementation rather than a captured HDR session.Verification: core unit tests,
cargo fmt --check, strict core Clippy, andgit diff --checkpass. Qt Windows tests and a live monitor comparison are pending on the local Windows build.