fix(stats): distinguish video bitrate from stream UDP receive rate - #1049
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
zortos293
marked this pull request as ready for review
September 24, 2026 17:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F3 previously called accepted encoded-video access-unit bytes “BITRATE,” which cannot match whole-adapter traffic: FEC, retransmissions, protocol bytes, audio, and unrelated applications have different accounting. Keep that correct video number and allocation bar under VIDEO BITRATE, and add UDP RX in the compact view plus STREAM UDP RECEIVE in the expanded view and report.
Count incoming datagram bytes from the established session peer on the bundle and dedicated video sockets with per-session counters. Sample their deltas on the existing one-second telemetry cadence, including video stalls; ignore foreign and pre-trust traffic and drop stale-session telemetry in Qt. This is stream socket traffic, not an estimate of all adapter bytes. QoS feedback remains unchanged.
Verification: streamer workspace tests and strict Clippy, localization validation, Windows Qt app build, native runtime test, and compact/expanded/scaled/degraded statistics acceptance pass. A live stream comparison remains pending.
Synthetic statistics fixture previews (cropped and exposure-adjusted for SDR viewing because Windows HDR screen grabs appear dark; these do not establish optical HDR accuracy):