Preserve physical gameplay keys across Linux keyboard layouts - #956
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![capy-ai[bot]](https://avatars.githubusercontent.com/in/1915919?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Resolve Linux gameplay keys from their XKB physical key codes before falling back to Qt logical keys. This preserves letter and punctuation positions on non-US layouts and distinguishes left and right modifiers. Windows and macOS mapping paths are unchanged.
Keep existing local-shortcut handling, clipboard paste, and scan-code-based press/release pairing. Add layout regressions through the real stream item in windowed and fullscreen modes, including overlay focus transitions and layout changes while a key is held.
Verification
Independently reviewed the diff and reran:
git diff --check: passed.The worker also ran real XTEST key injection with US, Russian, French, German, US-international, and Japanese layouts. The baseline dropped Cyrillic gameplay keys and several non-US punctuation keys. The new path sends the expected physical-position VKs.
The shifted-punctuation fixture now supplies each character's actual physical scan code instead of using the S-key scan code for every character. Its assertions and test name remain unchanged.
Limits
No live GFN session was available. Wayland's XKB key-code convention was checked against Qt 6.8.3 source but not exercised on a compositor. JIS-specific conversion/IME keys retain the prior fallback behavior and are not newly supported. No visual UI changes.