Fix bounded Opus packet-loss concealment in embedded Linux audio - #959
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Preserve sender SSRC and RTP timestamp through the embedded Linux audio handoff. Measure unrecovered loss from the RTP timeline and synthesize Opus concealment in valid sample chunks, capped at 100 ms and the existing PCM buffer capacity.
Reset Opus state when the sender source changes, including when a bounded queue drops the first packet from the new source. Decode RED-recovered packets normally without duplicate concealment.
Verification
This republishes unchanged commit
d41f07c9ad48fd00bf33ec41346f818eda513234from #955 after the user-authorized repair of an accidental direct push todev. The remote target has been restored to7a76b0c965087750d46411901ce8d04ba1b2524a. This replacement requires review; GitHub's historical merged status on #955 does not mean this change remains ondev.The orchestrator independently reviewed and tested this exact implementation before the branch repair:
Regressions cover RTP wrap, short/burst loss, varying packet durations, backward timestamps, source reset, a dropped first packet after source change, and RED recovery. CI will run again on this replacement PR.
Limits
No live GFN session, hardware decode, or real playback-device packet-loss test was available. The evidence is transport and real-libopus regression testing, not live gameplay validation. Audio-only failure isolation is a separate dependent change. No UI or FFI ABI changes.