Use one resolved Pictures root across Qt and the native core - #963
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This comment has been minimized.
This comment has been minimized.
|
Pushed The existing Rust child-process empty-marker test passed in the failed Windows job, so that contract still has Windows coverage. The job identified the three failing Qt binaries but did not expose their assertion output; the new Windows CI run must confirm the correction. Independent Linux rerun passed all 28 |
Changes
Resolve the Pictures directory in Qt and pass that root to the native core on every supported desktop platform, not only Flatpak. Use the same path policy for screenshot capture, copy, thumbnails, and recording targets.
Preserve explicit overrides and normalize nonempty paths to absolute paths. An explicit empty root means media storage is unavailable. The core reports a media-specific error instead of falling back to a directory relative to its working directory or failing unrelated startup work.
Verification
Independently reviewed the final Qt process-environment propagation and Rust path handling. Formatting, locked Clippy with warnings denied, and the full core suite passed, including three real-core process tests for media environment handling.
All 337 Qt tests passed across the independent suite and one interruption retry: 336 passed before a machine restart interrupted the performance test, and that remaining test passed when rerun. The three focused Qt tests also passed separately.
Regression coverage includes overrides, unavailable roots, platform fallback, capture and thumbnail path validation, and media errors without unrelated core startup failure.
Limits
Windows partial-path tests are present for Windows CI. Local Windows checks covered compilation and source-level path semantics, not execution on a Windows host. No live streaming account was used.