Add negotiated bandwidth-saving quality policy - #970
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Resolved the actual integration conflicts in normal merge Independent verification passed 574 core tests with 4 ignored and 773 bundled-FFmpeg native tests with 16 ignored, strict locked Clippy in both workspaces, and formatting. The worker rebuilt Qt, passed all 349 Qt tests, reran the real midstream-resolution-change fixture, and inspected the rendered bandwidth setting. Required cross-platform CI is now running on the updated head. |
Summary
Adds a default-off Save bandwidth control to the Qt desktop and console settings. New sessions request NVIDIA's prefer-FPS dynamic quality policy. The core preserves the policy in the negotiated session profile, and NVST ANNOUNCE uses that profile rather than a mutable preference. Resumed sessions keep their original policy.
The change also adds a real FFmpeg regression for a midstream resolution change. Existing decoder, format-change and Vulkan image-reallocation paths remain the presentation owners.
Independent verification
cargo test --manifest-path native/opennow-core/Cargo.toml --locked: 420 passed, 4 ignored.cargo test --manifest-path native/opennow-streamer/Cargo.toml --workspace --locked --features linux-ffmpeg-bundled: 681 passed, 16 ignored.ffmpeg_software_decoder_reports_a_midstream_resolution_change -- --ignored. It passed with real H.264 packets at 256x144 and 320x180.npm run locales:checkpassed.ctest --test-dir build/opennow-qt --output-on-failurepassed 342/342.No live vendor session, GPU adaptation measurement or bandwidth-reduction benchmark was performed. The setting requests the server policy; it does not promise a particular reduction.
Rendered acceptance fixture
Dependency
Base:
capy/enable-capability-gated-360-fpsatb470c330c59d411ad18eb03b5a629d0f8e920896. Land #968 and its parents first, then revalidate the integrated stack.