Recover native video stalls from actual frame progress - #972
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
capy-ai
Bot
changed the base branch from
capy/measure-native-frame-progress
to
dev
September 16, 2026 07:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds transport, decoder and Qt swap-stall recovery on top of the frame-stage measurements in #965.
trackingflag alone is not evidence. New swaps and decoder epochs reseed the baseline, and the first usable sample cannot borrow zero-valued placeholder progress.The runtime validates counters as finite, nonnegative exact JSON integers and scopes telemetry to the accepted start ID. A single-writer sequence-guarded snapshot uses paired release/acquire fences and bounded render-thread reads; an unsuccessful read supplies no usable evidence.
Independent verification
cargo test --locked --manifest-path native/opennow-streamer/Cargo.toml --workspace: 694 passed, 9 ignored.-D warningspassed.ctest --test-dir build/opennow-qt --no-tests=error --output-on-failure: 338/338 passed.Rendered Qt fixtures
The final binary passed the account-free stream UI fixture in windowed and fullscreen modes, with the overlay open and closed, under Xvfb and Vulkan. The black video background is expected because these fixtures do not start media. They verify stream chrome and retained-surface behavior, not real GPU-stall recovery.
Limits and dependency
No authenticated session or real GPU stall was exercised. A larger decoded-output count proves observed progress since the stored baseline, not an exact producer observation time or absolute exclusion between asynchronous recovery paths.
Base:
capy/measure-native-frame-progressat310528ea8c7d462ebb175269f048c12e7dd99cf9. Land #965 first and revalidate the combined stack before merging.