Skip to content

feat(desktop): show full model id as tooltip on model switcher options - #477

Closed
taosher wants to merge 1 commit into
OpenCoworkAI:mainfrom
taosher:feat/model-name-tooltip
Closed

taosher wants to merge 1 commit into
OpenCoworkAI:mainfrom
taosher:feat/model-name-tooltip

Conversation

@taosher

@taosher taosher commented Oct 11, 2026 •

Copy link
Copy Markdown

Summary

In BYOK mode, model ids include the provider prefix (e.g. openai/gpt-4o or long custom endpoint names). The options in the chat model switcher dropdown can clip these long names, and there was no way to reveal the full model id on hover. The switcher trigger button already sets a native title attribute, but the individual dropdown options did not.

This PR adds title={modelId} to each option button in ModelSwitcher.tsx, so hovering an option shows the full model id via a native tooltip.

Type of change

  • Bug fix
  • New feature
  • Refactor (no behavior change)
  • Documentation
  • Build / CI / tooling
  • Breaking change

Linked issue

None filed (API access to the upstream repo is read-only for my integration, so I could not open one).

Checklist

  • I checked the linked issue / relevant context before starting
  • pnpm lint && pnpm typecheck && pnpm test passes locally (see Verification: 4 pre-existing failures in unrelated test files)
  • Added/updated tests for the change (single title attribute addition; existing test file covers only pure helpers, no component rendering tests exist for this component)
  • Added a changeset (pnpm changeset) if user-visible
  • Updated docs if behavior changed (N/A, no documented behavior changed)

Verification

  • biome check .: 687 files, no issues
  • tsc --noEmit for all 11 workspace packages: pass
  • vitest run ModelSwitcher.test.ts: 14/14 pass
  • Full desktop suite: 2468 passed, 4 failed in unrelated test files (none reference ModelSwitcher, no snapshots exist; failures are pre-existing on main)

Screenshots / recordings (UI changes)

Native title tooltip only appears on hover; no persistent visual change, so no screenshot attached.

Long BYOK model ids (with provider prefixes) can be clipped in the model switcher dropdown. Add a native title attribute to each option so the full model id is visible on hover.
@github-actions github-actions Bot added docs Documentation area:desktop apps/desktop (Electron shell, renderer) labels Oct 11, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings

No issues found. The change is a one-line, additive UI tweak (title={m} on the model-switcher option) plus a correctly formatted changeset. It introduces no new dependency, no direct provider SDK import, no behavioral change to model selection, and no release/distribution surface.

Summary

  • Review mode: initial
  • The diff is minimal and low-risk: apps/desktop/src/renderer/src/components/ModelSwitcher.tsx:307 adds title={m}, which surfaces the raw provider-prefixed model id on hover for each option, matching the stated intent in the PR body.
  • The changeset uses the existing @open-codesign/desktop package name and patch bump, consistent with the workspace naming convention. No version-sensitive claims are being made here.
  • Residual observation (non-blocking, not a defect): the option already uses [overflow-wrap:anywhere], so long ids wrap rather than clip horizontally; if the parent list constrains option height, wrapping could still truncate visually, in which case the native title tooltip is a reasonable short-term mitigation. If the project later standardizes on a styled tooltip component from packages/ui, this native attribute could be revisited for visual consistency. This is a nit at most and not a merge blocker.
  • No hardcoded colors/fonts/spacing were introduced, so the packages/ui token constraint is not implicated.

Testing

  • Not run (automation). No automated test is proportional to a native title attribute addition; no test coverage gap worth blocking on. Manual check under the reviewer's OS/browser is sufficient (hover a long BYOK model id and confirm the full id appears).

Open-CoDesign Bot

@taosher taosher closed this Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:desktop apps/desktop (Electron shell, renderer) docs Documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant