Repository navigation
Conversation
Long BYOK model ids (with provider prefixes) can be clipped in the model switcher dropdown. Add a native title attribute to each option so the full model id is visible on hover.
Contributor
There was a problem hiding this comment.
Findings
No issues found. The change is a one-line, additive UI tweak (title={m} on the model-switcher option) plus a correctly formatted changeset. It introduces no new dependency, no direct provider SDK import, no behavioral change to model selection, and no release/distribution surface.
Summary
- Review mode: initial
- The diff is minimal and low-risk:
apps/desktop/src/renderer/src/components/ModelSwitcher.tsx:307addstitle={m}, which surfaces the raw provider-prefixed model id on hover for each option, matching the stated intent in the PR body. - The changeset uses the existing
@open-codesign/desktoppackage name andpatchbump, consistent with the workspace naming convention. No version-sensitive claims are being made here. - Residual observation (non-blocking, not a defect): the option already uses
[overflow-wrap:anywhere], so long ids wrap rather than clip horizontally; if the parent list constrains option height, wrapping could still truncate visually, in which case the nativetitletooltip is a reasonable short-term mitigation. If the project later standardizes on a styled tooltip component frompackages/ui, this native attribute could be revisited for visual consistency. This is a nit at most and not a merge blocker. - No hardcoded colors/fonts/spacing were introduced, so the
packages/uitoken constraint is not implicated.
Testing
- Not run (automation). No automated test is proportional to a native
titleattribute addition; no test coverage gap worth blocking on. Manual check under the reviewer's OS/browser is sufficient (hover a long BYOK model id and confirm the full id appears).
Open-CoDesign Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In BYOK mode, model ids include the provider prefix (e.g.
openai/gpt-4oor long custom endpoint names). The options in the chat model switcher dropdown can clip these long names, and there was no way to reveal the full model id on hover. The switcher trigger button already sets a nativetitleattribute, but the individual dropdown options did not.This PR adds
title={modelId}to each option button inModelSwitcher.tsx, so hovering an option shows the full model id via a native tooltip.Type of change
Linked issue
None filed (API access to the upstream repo is read-only for my integration, so I could not open one).
Checklist
pnpm lint && pnpm typecheck && pnpm testpasses locally (see Verification: 4 pre-existing failures in unrelated test files)titleattribute addition; existing test file covers only pure helpers, no component rendering tests exist for this component)pnpm changeset) if user-visibleVerification
biome check .: 687 files, no issuestsc --noEmitfor all 11 workspace packages: passvitest run ModelSwitcher.test.ts: 14/14 passModelSwitcher, no snapshots exist; failures are pre-existing onmain)Screenshots / recordings (UI changes)
Native
titletooltip only appears on hover; no persistent visual change, so no screenshot attached.