detect and warn collinearity of GCPs - #40
Open
originlake wants to merge 1 commit into
Open
Conversation
Member
|
@originlake, first of all, please accept our apologies for the delay in responding to you. We are going over old PR and issues now, as we have gone through some changes in the org. The changes seem reasonable and computationally given the amount of GCP is negligible, while the warning is very useful for those who need to look into the logs. If you could add it on 370 (based on the latest opensfm/opensfm), I will approve, or I could bring the changes myself if you prefer. Waiting for your answer :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds a feature to detect collinearity of GCPs based on PCA analysis and warn about possible inaccuracy.