Skip to content

Fix audio encoder channel handling and release analysis findings - #365

Merged
TobiasRoeddiger merged 4 commits into
2.2.10from
codex/release-analysis-fixes
Oct 6, 2026
Merged

TobiasRoeddiger merged 4 commits into
2.2.10from
codex/release-analysis-fixes

Conversation

@TobiasRoeddiger

@TobiasRoeddiger TobiasRoeddiger commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

The encoder could use an uninitialized frame length when input/output channel locations did not overlap. Selecting only the right channel from stereo input also read the left channel, and mono-to-mono input was rejected. Validate overlap, track the input channel independently, and normalize mono consistently. Seven regression tests exercise the production wrapper with a stub LC3 codec.

Also clear the other CodeChecker findings, make the intentional pressure-timing conversion explicit, and align the beta publisher with main to remove the release PR’s workflow conflict. The audio-buffer fatal policy is preserved.

Validation:

  • Normal and FOTA firmware builds pass locally; GitHub firmware build passes.
  • All five unit-test suites pass, including seven encoder tests. A host harness reproduces four failures before the patch and passes all seven cases afterward with address/undefined-behavior sanitizers.
  • CodeChecker: zero non-style findings (previously eight).
  • Publisher fixtures pass for modern ZIP, legacy ELF, missing artifacts, and version names; a trial merge with current main has no conflicts.
  • The compiler check passes with the existing legacy USB API deprecation remaining. No hardware flash or listening test was performed for this PR.

Targets the 2.3.0 release branch, currently named 2.2.10 (#295).

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

✅ Unit tests passed

5 passed, 0 failed/error, 0 skipped — view workflow run

Test scenario Platform Result
openearable.unit.sensor_component native_sim/native/64 ✅ passed
openearable.unit.sensor_transport native_sim/native/64 ✅ passed
openearable.unit.ring_buffer native_sim/native/64 ✅ passed
openearable.unit.audio_encoder native_sim/native/64 ✅ passed
openearable.unit.audio_startup native_sim/native/64 ✅ passed

Download the unit-test-results artifact for full Twister reports and logs.

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Compiler warnings

The extended-warning build completed successfully.

Application compiler warnings

Show warnings
unicast_server/main.cpp:78:33: warning: 'int usb_enable(usb_dc_status_callback)' is deprecated [-Wdeprecated-declarations]

View this workflow run

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

CodeChecker static analysis

✅ No non-style issues found.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

Build output available:
openearable_v2_firmware.zip
openearable_v2_fota.zip

@TobiasRoeddiger
TobiasRoeddiger marked this pull request as ready for review October 6, 2026 10:45
@TobiasRoeddiger
TobiasRoeddiger merged commit 425bb57 into 2.2.10 Oct 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant