Repository navigation
Fix audio encoder channel handling and release analysis findings - #365
Merged
Merged
Conversation
✅ Unit tests passed5 passed, 0 failed/error, 0 skipped — view workflow run
Download the |
Compiler warningsThe extended-warning build completed successfully. Application compiler warningsShow warnings |
CodeChecker static analysis✅ No non-style issues found. |
|
Build output available: |
TobiasRoeddiger
marked this pull request as ready for review
October 6, 2026 10:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The encoder could use an uninitialized frame length when input/output channel locations did not overlap. Selecting only the right channel from stereo input also read the left channel, and mono-to-mono input was rejected. Validate overlap, track the input channel independently, and normalize mono consistently. Seven regression tests exercise the production wrapper with a stub LC3 codec.
Also clear the other CodeChecker findings, make the intentional pressure-timing conversion explicit, and align the beta publisher with main to remove the release PR’s workflow conflict. The audio-buffer fatal policy is preserved.
Validation:
Targets the 2.3.0 release branch, currently named
2.2.10(#295).