Tighten exec commands to prevent injection attacks#1468
Merged
Conversation
josephjclark
added a commit
that referenced
this pull request
Jul 2, 2026
* CLI: Deploy through v1 API with v2 spec (#1465) * convert v2 spec down to v1 * refactor to make a version-sniffing util * integrate the new feature * test * Add special case for to-app-state to convert a project to a v1 spec stucture * Add validation to mock provisioner * experiment with using Project to generate a spec file from state * format * restore tests * little style tweak * remove state.json * handle credentials properly in spec * update tests * mock: handle deleted edges * fix tests * correct project credential name * one more test for luck * one more test fix and log removal * tighten exec commands to prevent injection attacks (#1468) * remove debug code * cli: bump undici version (#1469) * cli: bump undici version * fix and changeset * fix test * format * versions: cli@1.38.2 worker@1.27.1 * update changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description
This PR adds a redunant guard to the autoinstall commands in the runtime to ensure that the adaptor name cannot contain injection attacks.
It is redundant because the adaptor specifier strings which are used in exec commands are send by Lightning, which has its own security measures to ensure that strings are valid and legal. In production it's very hard, if not impossible, to pass naughty adaptor values
Nevertheless the runtime should be independently secure and frankly it 's only good practice to not trust lightning too much.
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy