Skip to content

Handle missing light-link values - #12

Open
nicolaspopravka wants to merge 1 commit into
OpenMoonRay:mainfrom
nicolaspopravka:fix-empty-light-link-values
Open

Handle missing light-link values#12
nicolaspopravka wants to merge 1 commit into
OpenMoonRay:mainfrom
nicolaspopravka:fix-empty-light-link-values

Conversation

@nicolaspopravka

@nicolaspopravka nicolaspopravka commented Aug 13, 2026

Copy link
Copy Markdown

Compatibility:

patch

Issues/Tickets:

nicolaspopravka/usd-render-benchmark#23

Release notes comment:

Handle missing light-link and shadow-link values without reporting coding errors.

Comments for the reviewer:

HdSceneDelegate::GetLightParamValue() may return an empty VtValue when the optional lightLink or shadowLink parameter is absent.

Light::Sync() currently calls Get<TfToken>() unconditionally for both parameters. This change checks that each value contains a TfToken and otherwise uses an empty category.

Testing:

Look or scene setup change:

Special notes for production:

Attention/Reviewers:

AI Assisted Development:

Assisted-by: OpenAI Codex / GPT-5

Checklist:

  • Documentation has been updated.
  • Includes new unit tests.
  • Includes new RATS tests.

Signed-off-by: Nicolas Popravka <nicolaspopravka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant