fix: cycle through system theme in ThemeToggle - #109
Open
06mia wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The theme toggle button currently only switches between light and dark. Users who set the theme to "system" in Preferences have no way to cycle back to it from the toggle — they have to go to Settings. This PR adds system to the toggle cycle.
Current behavior: light <-> dark (binary toggle)
New behavior: light -> dark -> system -> light (3-way cycle)
Changes in
frontend/src/components/layout/ThemeToggle.tsxMonitoricon import from lucide-react for the system theme indicatorThemetype from the theme hook for type-safe cycle definitionTHEME_CYCLEarray (['light', 'dark', 'system']) and anextTheme()helper that advances through the cycletheme(the stored preference) in addition toresolvedTheme(the effective value after resolving "system"), so the cycle operates on the user's actual selection rather than the resolved valuetheme === 'system', Sun when resolved is dark, Moon when resolved is lightWhy
themevsresolvedThememattersThe cycle must operate on what the user selected, not what the OS is currently reporting. If the user picks "system" and their OS is dark,
resolvedThemeis'dark'. With the old code, clicking would set theme to'light'— skipping system entirely. By cycling ontheme, the three states are all reachable.