fix: add max_length to code_context_api.py BuildContextRequest.repoPath - #95
Open
norascott407 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there, first time contributing here. I was reading through the code_context_api module and noticed that the BuildContextRequest model does not constrain the length of the repoPath field. Since this path is used in filesystem operations, an unbounded string could be problematic.
This adds a max_length=1024 constraint to the repoPath Field in BuildContextRequest (backend/app/modules/code/code_context_api.py, line 32). Pydantic handles validation automatically and returns a 422 error with a clear message when the limit is exceeded.
I also added a test file (backend/tests/test_pr_16_code_context_validation.py) with four cases:
All tests pass. Let me know if anything needs adjusting.