Repository navigation
[samplestorage] Fixing ClearSurface and ClearVolume keeping the zero-value samples - #46
Merged
sherholz merged 1 commit intoNov 8, 2026
Conversation
…value samples Signed-off-by: Euan Hughes <realeuanhughes@gmail.com>
Contributor
|
@wantonsushi good catch. The fix looks good. |
sherholz
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pglSampleStorageClearSurfaceandpglSampleStorageClearVolumeonly clears non-zero samples, whilepglSampleStorageClearclears both. All three are documented the same way (cpp/SampleStorage.h:86-93: "Clears all internal list of … samples"), so I assume this is a bug.I added one surface and one volume zero-value sample to a
SampleStorage, then calledClearSurface()andClearVolume().GetSizeZeroValueSurface()andGetSizeZeroValueVolume()should both return 0. Instead they still return 1. repro.cppThe fix is to also call
clearInvalidSurface()andclearInvalidVolume(), just likepglSampleStorageClearalready does.