Skip to content

[kdtree] Fixing KDTree::m_bounds being uninitialized until the tree is built - #48

Merged
sherholz merged 1 commit into
OpenPathGuidingLibrary:develfrom
wantonsushi:fix-kdtree-bounds
Nov 8, 2026
Merged

sherholz merged 1 commit into
OpenPathGuidingLibrary:develfrom
wantonsushi:fix-kdtree-bounds

Conversation

@wantonsushi

Copy link
Copy Markdown
Contributor

Same issue as #47, for KDTree::m_bounds: it stays uninitialized until the tree is built. So Store() writes uninitialized bytes for a field whose surface or volume tree was never built, e.g. in a scene without volumes.

The fix is to initialize it as embree::empty.

…s built

Signed-off-by: Euan Hughes <realeuanhughes@gmail.com>
@sherholz
sherholz merged commit 7459c5e into OpenPathGuidingLibrary:devel Nov 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants