Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions openpgl/directional/vmm/VMMPhaseFunctions.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,17 @@ void VMMSingleLobeHenyeyGreensteinOracle::init()
maxMeanCosine = 0.99f;
numRepresentations = 128;

representations[0].K = 3;
representations[0].K = 1;
representations[0].g = 0.0f;
representations[0].weights[0] = 0.01688512612073299f;
representations[0].weights[0] = 1.0f;
representations[0].meanCosines[0] = 0.0f;
representations[0].kappas[0] = 0.0f;
representations[0].normalizations[0] = 0.07957747154594767f;
representations[0].weights[1] = 0.34940739552081895f;
representations[0].weights[1] = 0.0f;
representations[0].meanCosines[1] = 0.0f;
representations[0].kappas[1] = 0.0f;
representations[0].normalizations[1] = 0.07957747154594767f;
representations[0].weights[2] = 0.6337074783584481f;
representations[0].weights[2] = 0.0f;
representations[0].meanCosines[2] = 0.0f;
representations[0].kappas[2] = 0.0f;
representations[0].normalizations[2] = 0.07957747154594767f;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The normalization factor should still be the one for a kappa of zero VMF lobe to be valid.
Only the weights of the other components need to be set to 0.0.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. For the record, I did it that way because all the slot [3] entries do $\kappa=0$ with normalization 0.

Expand Down