Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions openpgl/data/PathSegmentDataStorage.h
Original file line number Diff line number Diff line change
Expand Up @@ -248,8 +248,8 @@ struct PathSegmentDataStorage
openpgl::Vector3(currentPathSegment.scatteringWeight.x, currentPathSegment.scatteringWeight.y, currentPathSegment.scatteringWeight.z);
openpgl::Vector3 scatteredContribution =
openpgl::Vector3(currentPathSegment.scatteredContribution.x, currentPathSegment.scatteredContribution.y, currentPathSegment.scatteredContribution.z);
//openpgl::Vector3 directContribution =
// openpgl::Vector3(currentPathSegment.directContribution.x, currentPathSegment.directContribution.y, currentPathSegment.directContribution.z);
// openpgl::Vector3 directContribution =
// openpgl::Vector3(currentPathSegment.directContribution.x, currentPathSegment.directContribution.y, currentPathSegment.directContribution.z);
#endif
float pdf = std::max(minPDF, currentPathSegment.pdfDirectionIn);
uint32_t flags{0};
Expand Down
3 changes: 1 addition & 2 deletions openpgl/data/SampleData.h
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,7 @@ inline bool ZeroValueSampleDataLess(const PGLZeroValueSampleData &compA, const P
#ifndef PGL_USE_DIRECTION_COMPRESSION
&& (compA.direction.x < compB.direction.x ||
(compA.direction.x == compB.direction.x &&
(compA.direction.y < compB.direction.y ||
(compA.direction.y == compB.direction.y && (compA.direction.z < compB.direction.z)))))
(compA.direction.y < compB.direction.y || (compA.direction.y == compB.direction.y && (compA.direction.z < compB.direction.z)))))
#else
&& compA.direction.compressed_direction < compB.direction.compressed_direction
#endif
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -980,7 +980,7 @@ inline void ParallaxAwareVonMisesFisherMixture<VecSize, maxComponents, UseParall
float cdf = 0.0f;

const uint32_t quot = (_numComponents - 1) / VecSize;
const uint32_t rem = (_numComponents - 1) % VecSize;;
const uint32_t rem = (_numComponents - 1) % VecSize;

selectedVector = 0;
selectedComponent = 0;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1415,7 +1415,8 @@ void ParallaxAwareVonMisesFisherWeightedEMFactory<TVMMDistribution>::updateCompo
#ifdef OPENPGL_RADIANCE_CACHES
template <class TVMMDistribution>
void ParallaxAwareVonMisesFisherWeightedEMFactory<TVMMDistribution>::updateFluenceEstimate(VMM &vmm, const SampleData *samples, const size_t numSamples,
const size_t numZeroValueSamples, [[maybe_unused]]const SampleStatistics &sampleStatistics) const
const size_t numZeroValueSamples,
[[maybe_unused]] const SampleStatistics &sampleStatistics) const
{
#ifdef MC_ESTIMATE_INCOMING_RADIANCE // calcualting fluence and the RGB per lob estiamtions using the MC samples
if (numSamples == 0)
Expand Down
2 changes: 1 addition & 1 deletion openpgl/imagespace/ImageSpaceGuidingBuffer.h
Original file line number Diff line number Diff line change
Expand Up @@ -759,7 +759,7 @@ struct ImageSpaceGuidingBuffer
m_contributionEstimateBuffers->spp[pixelIdx] += 1;
float alpha = 1.f / m_contributionEstimateBuffers->spp[pixelIdx];

//const pgl_vec3f quantity = m_cfg.contributionType == PGLContributionTypes::EContribContribution ? sample.contribution : sample.contribution * sample.contribution;
// const pgl_vec3f quantity = m_cfg.contributionType == PGLContributionTypes::EContribContribution ? sample.contribution : sample.contribution * sample.contribution;
m_contributionEstimateBuffers->contribution[pixelIdx] = (1.f - alpha) * m_contributionEstimateBuffers->contribution[pixelIdx] + alpha * sample.contribution;
m_contributionEstimateBuffers->albedo[pixelIdx] = (1.f - alpha) * m_contributionEstimateBuffers->albedo[pixelIdx] + alpha * sample.albedo;
m_contributionEstimateBuffers->normal[pixelIdx] = (1.f - alpha) * m_contributionEstimateBuffers->normal[pixelIdx] + alpha * sample.normal;
Expand Down
Loading