Repository navigation
match func_L01_002F0728 (elevator partner spawn) - #106
Merged
Merged
Conversation
Levels 01, 05 and 11 share this function. It finds the moby that pairs with this one's class (0x23C -> 0x361, 0x361 -> 0x362) in the group's entity list and copies this moby's distances, spawn frame, flags, position, rotation and two pvar floats onto it. What made it exact: - the entity table is read after the null-list test, not before it (reading it earlier kept the list base live longer and swapped two register pairs); - both misses go through one `return 0`, which retail falls into from the list test and jumps back to from the scan loop. Drops the near-miss draft and its functional.tsv and README rows; progress/report.json regenerated (5054/5124, --check passes). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ByteMatch progress report
✅ Newly matched (1)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches
func_L01_002F0728, the elevator's partner-spawn function. It's shared by levels 01, 05 and 11, and all three copies are exact.What it does: it picks the class that pairs with this moby's (0x23C → 0x361, 0x361 → 0x362), walks its group's entity list (
D_L01_001ABFC0[group], bit 15 marks the last entry) for a live moby of that class, copies this moby's update distance, draw distance, spawn frame, flags, position, rotation and two pvar floats onto it, refreshes it withfunc_L00_00251E30and returns it.What made it exact (it had been 2/296 bytes off):
D_L01_00160058) is read after the null-list test. Reading it before kept the list base address live longer and swapped two register pairs.return 0. Retail falls into it from the list test and jumps back to it from the scan loop.Changes
src/overlays/shared/vendor_002B90A8.c: C definition in place of theINCLUDE_ASMstub (applied withtools/integrate.py).nonmatching/shared/func_L01_002F0728.cand itsfunctional.tsvand README rows.progress/report.jsonregenerated: 5053 → 5054 of 5124 functions.Checks
tools/overlay_file_check.pyon the changed file: 0 problems.bash tools/build_sn.sh: 1233/1233 exact, image matches retail.python tools/gen_progress_report.py --check: passes.🤖 Generated with Claude Code