Repository navigation
Match 69 US near misses and drafts (50 net, 4 game, 3 core, 12 overlay) - #135
Merged
Merged
Conversation
Near misses from earlier batches and nonmatching/ drafts, closed with comparison operand order, -fno-optimize-sibling-calls, field and argument types, pointer steps, store order and profiles. Superseded nonmatching/ drafts and their README rows are removed. The map rows change only for these functions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ByteMatch progress reportSCUS_974.65
✅ Newly matched (68)
📉 Worse (1)
SCES_532.85
✅ Newly matched (66)
|
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches 69 US functions (50 in
net.text, 4 ingame, 3 incore, 12 in level overlays): near misses from my earlier batches and drafts that are now exact, plus a few from a fresh batch.How they were matched
Most were a few instructions off. What closed them:
a->x < a->y; writtena->y > a->xit matches. This closed a family ofnet.textassert getters at once (func_01F056C8,func_01F0574C,func_01F060F4,func_01F06248,func_01F0B0EC,func_01F0B150,func_01F0B478,func_01F0B6D8,func_01F0B778, ...).-fno-optimize-sibling-callswhere retail calls withjaland returns instead of tail-calling (severalnet.textfunctions, under@ee296).u8/s8/s16/u16/f32fields where retail useslbu/lb/lh/lhu/lwc1; callees with the argument count retail sets up (an assert taking two arguments, a fifth argument in$t0,memset(arg0, 0, n)where m2c droppedarg0).s32 *p; p -= 4that is 4 bytes,arr[i]fori * 4 + &arr).docs/TOOLCHAIN.mddocuments (@ee296,@ee29,@ee32-040921,-G0,-mno-split-addresses,-fno-optimize-sibling-calls).gotoloops where aforadds an alignmentnop).No
#definealiases,volatile, inline asm or hard-coded addresses: m2c's#define D_x (D_x_[0])aliases are replaced withextern T D_x[]indexed[0].func_01EEE33Chad a draft innonmatching/; the draft and its README row are removed.Functions
func_00140D20,func_00140F18,func_00157728,func_00490954,func_00498950,func_004E2554,func_004F6288,func_01EA57F8,func_01EA70B0,func_01EA96A8,func_01EC34B8,func_01EC3DE0,func_01ED5D30,func_01EDA870,func_01EDC318,func_01EDD4D0,func_01EE00A0,func_01EE94B4,func_01EED5B8,func_01EEE19C,func_01EEE1FC,func_01EEE27C,func_01EEE2DC,func_01EEE33C,func_01EEE39C,func_01EEE3FC,func_01EEE45C,func_01EEED4C,func_01EEEDD0,func_01EF0C54,func_01EF6E5C,func_01EFC4E8,func_01EFDC88,func_01EFE4DC,func_01F00074,func_01F002FC,func_01F03864,func_01F03B10,func_01F056C8,func_01F0574C,func_01F060F4,func_01F06248,func_01F06308,func_01F07170,func_01F07DC8,func_01F07E8C,func_01F07F50,func_01F09ADC,func_01F09D00,func_01F0A2A0,func_01F0B0EC,func_01F0B150,func_01F0B478,func_01F0B6D8,func_01F0B778,func_01F0C4EC,func_01F0C7D4,func_L00_005134B0,func_L00_00520A68,func_L00_00538038,func_L00_00538220,func_L00_00548040,func_L00_00566BF0,func_L00_00710F30,func_L00_00719F68,func_L00_00764CF0,func_L00_0076DED0,func_L01_0047ECC8,func_L01_004B7770Verification
On
mainat 4a7372f:tools/build.sh,build_libgcc.sh,build_libm.sh;tools/audit_matches.pyandtools/audit_relocs.py: no line names any of these functions;config/{us,pal}/map.tsvchanged only on these rows (match_map --writewith and without the new files, applied as a delta), thenmatch_map --check;progress.py --checkfor US and PAL: US 7,163 → 7,231 and PAL 7,644 → 7,709 (counts are per distinct function).Independent of #128, #130 and #132 (no file in common).
Reserved in #112.
🤖 Generated with Claude Code