Skip to content

match(pal): add twenty-three strictly verified overlay routines - #137

Open
Shaar-games wants to merge 1 commit into
OpenRAC:mainfrom
Shaar-games:codex/pal-solver-scope12-20261109
Open

Shaar-games wants to merge 1 commit into
OpenRAC:mainfrom
Shaar-games:codex/pal-solver-scope12-20261109

Conversation

@Shaar-games

@Shaar-games Shaar-games commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds twenty-three PAL overlay routines for SCES_532.85, each strictly verified with pal-solver verify (byte-identical linked code plus verified data/BSS) against the PAL catalogue.

New matches

Function Program Section Size
func_00484F88 main .text 200
func_01EEE13C main net.text 96
func_L00_005300C8 level_00 .text 196
func_L00_00530410 level_00 .text 196
func_L00_00567138 level_00 .text 68
func_L00_00605A70 level_00 .text 228
func_L00_00605B58 level_00 .text 228
func_L00_006A09B8 level_00 .text 276
func_L00_006A0F88 level_00 .text 276
func_L02_004CF080 level_02 .text 100
func_L05_003E47B8 level_05 .text 68
func_L05_004EF810 level_05 .text 108
func_L05_004F0FD8 level_05 .text 108
func_L05_004F4E68 level_05 .text 68
func_L06_004C5DF0 level_06 .text 220
func_L08_004B9CC0 level_08 .text 96
func_L11_00408630 level_11 .text 84
func_L15_004EDFA0 level_15 .text 128
func_L41_00410098 level_41 .text 68
func_L41_00410298 level_41 .text 68
func_L41_00444C58 level_41 .text 68
func_L41_00444D18 level_41 .text 68
func_L41_004469F8 level_41 .text 40

Verification

Every routine was produced by the pal-solver campaigns (scope 12 and scope 13) and confirmed with a strict pal-solver verify MATCH after m2c boilerplate cleanup. The PAL and US maps were updated with tools/match_map.py --update-native and progress regenerated (PAL total now 8,067 of 18,134 functions).

Checks

  • tools/match_map.py --version pal --check and --version us --check both pass (8684 rows)
  • tools/progress.py --check passes

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T22:50:45.688365Z 881bb02 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@bytematchdev

bytematchdev Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

ByteMatch progress report

SCES_532.85

Code matched 14.67% (+0.05%) · 852.65 KB of 5.81 MB
Fuzzy match 15.41% (+0.05%)
Functions 8,067 (+23) / 18,134
Units complete 4,379 (+2) / 4,437
✅ Newly matched (23)
  • func_L00_006A09B8 (276 bytes)
  • func_L00_006A0F88 (276 bytes)
  • func_L00_00605A70 (228 bytes)
  • func_L00_00605B58 (228 bytes)
  • func_L06_004C5DF0 (220 bytes)
  • func_00484F88 (200 bytes)
  • func_L00_005300C8 (196 bytes)
  • func_L00_00530410 (196 bytes)
  • func_L15_004EDFA0 (128 bytes)
  • func_L05_004EF810 (108 bytes)
  • func_L05_004F0FD8 (108 bytes)
  • func_L02_004CF080 (100 bytes)
  • func_01EEE13C (96 bytes)
  • func_L08_004B9CC0 (96 bytes)
  • func_L11_00408630 (84 bytes)
  • func_L05_003E47B8 (68 bytes)
  • func_L00_00567138 (68 bytes)
  • func_L05_004F4E68 (68 bytes)
  • func_L41_00410098 (68 bytes)
  • func_L41_00410298 (68 bytes)
  • func_L41_00444C58 (68 bytes)
  • func_L41_00444D18 (68 bytes)
  • func_L41_004469F8 (40 bytes)

SCUS_974.65

Code matched 12.88% · 744.88 KB of 5.78 MB
Fuzzy match 13.75%
Functions 7,673 / 18,170
Units complete 4,225 / 4,284

No function changes.

Commit 881bb02 · Ratchet: Deadlocked on ByteMatch

Strictly verified (pal-solver verify, byte-identical linked code and
verified data/BSS) against PAL SCES_532.85:

  main/multiplayer: 00484F88   net: 01EEE13C
  L00: 005300C8 00530410 00567138 00605A70 00605B58 006A09B8 006A0F88
  L02: 004CF080   L05: 003E47B8 004EF810 004F0FD8 004F4E68
  L06: 004C5DF0   L08: 004B9CC0  L11: 00408630  L15: 004EDFA0
  L41: 00410098 00410298 00444C58 00444D18 004469F8

PAL catalogue 8,044 -> 8,067 of 18,134 functions (incl. OpenRAC#133 baseline).
@Shaar-games
Shaar-games force-pushed the codex/pal-solver-scope12-20261109 branch from a83dd5b to 881bb02 Compare November 10, 2026 22:44
@Shaar-games Shaar-games changed the title match(pal): add nine strictly verified overlay routines match(pal): add twenty-three strictly verified overlay routines Nov 10, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 881bb02585

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

extern s32 func_00474368(void *, s32, s32);

void func_L05_004EF810(u8 *arg0) {
if (func_L01_0058A000() == 0) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Pass the object argument to func_L01_0058A000

Both new Dark Cathedral handlers call this helper without its required object argument. The existing definition in src/pal/overlays/shared/L01_0058A000.c:5–7 takes void *arg0, passes it to another lookup, and conditionally updates the object at +0x34. The unprototyped extern ...() hides the argument-count mismatch, producing an undefined C call that only works if $a0 happens to retain the incoming object pointer. Pass arg0 explicitly and declare the matching prototype here and in the new L05_004F0FD8.c handler.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant