Repository navigation
match(pal): add twenty-three strictly verified overlay routines - #137
Shaar-games wants to merge 1 commit into
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ByteMatch progress reportSCES_532.85
✅ Newly matched (23)
SCUS_974.65
No function changes. Commit 881bb02 · Ratchet: Deadlocked on ByteMatch |
Strictly verified (pal-solver verify, byte-identical linked code and verified data/BSS) against PAL SCES_532.85: main/multiplayer: 00484F88 net: 01EEE13C L00: 005300C8 00530410 00567138 00605A70 00605B58 006A09B8 006A0F88 L02: 004CF080 L05: 003E47B8 004EF810 004F0FD8 004F4E68 L06: 004C5DF0 L08: 004B9CC0 L11: 00408630 L15: 004EDFA0 L41: 00410098 00410298 00444C58 00444D18 004469F8 PAL catalogue 8,044 -> 8,067 of 18,134 functions (incl. OpenRAC#133 baseline).
a83dd5b to
881bb02
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 881bb02585
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| extern s32 func_00474368(void *, s32, s32); | ||
|
|
||
| void func_L05_004EF810(u8 *arg0) { | ||
| if (func_L01_0058A000() == 0) { |
There was a problem hiding this comment.
Pass the object argument to func_L01_0058A000
Both new Dark Cathedral handlers call this helper without its required object argument. The existing definition in src/pal/overlays/shared/L01_0058A000.c:5–7 takes void *arg0, passes it to another lookup, and conditionally updates the object at +0x34. The unprototyped extern ...() hides the argument-count mismatch, producing an undefined C call that only works if $a0 happens to retain the incoming object pointer. Pass arg0 explicitly and declare the matching prototype here and in the new L05_004F0FD8.c handler.
Useful? React with 👍 / 👎.
Summary
Adds twenty-three PAL overlay routines for SCES_532.85, each strictly verified with
pal-solver verify(byte-identical linked code plus verified data/BSS) against the PAL catalogue.New matches
Verification
Every routine was produced by the pal-solver campaigns (scope 12 and scope 13) and confirmed with a strict
pal-solver verifyMATCH after m2c boilerplate cleanup. The PAL and US maps were updated withtools/match_map.py --update-nativeand progress regenerated (PAL total now 8,067 of 18,134 functions).Checks
tools/match_map.py --version pal --checkand--version us --checkboth pass (8684 rows)tools/progress.py --checkpasses