Repository navigation
Conversation
PAL-only; matches its PAL bytes with tools/check_func.py --version pal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PAL-only; matches its PAL bytes with tools/check_func.py --version pal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PAL-only; matches its PAL bytes with tools/check_func.py --version pal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PAL-only; matches its PAL bytes with tools/check_func.py --version pal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PAL-only; matches its PAL bytes with tools/check_func.py --version pal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PAL-only; matches its PAL bytes with tools/check_func.py --version pal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PAL-only; matches its PAL bytes with tools/check_func.py --version pal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PAL-only; matches its PAL bytes with tools/check_func.py --version pal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PAL-only; matches its PAL bytes with tools/check_func.py --version pal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PAL-only; matches its PAL bytes with tools/check_func.py --version pal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PAL-only; matches its PAL bytes with tools/check_func.py --version pal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
11 PAL-only functions, one commit each, all reserved in #112 (my comment there).
src/pal/game/src/pal/game/src/pal/overlays/shared/src/pal/overlays/l15_control_level/src/pal/overlays/shared/src/pal/game/src/pal/overlays/shared/src/pal/game/src/pal/overlays/shared/src/pal/overlays/shared/src/pal/game/Checks: every file in
src/pal/MATCHES withtools/check_func.py --version pal, checked withsrc/pal/set aside. The only failures are four files that fail in my checker only, as before:L15_004D8550.c,L01_00496500.c,L01_004AC708.candcore/0012C680.c. The branch is based onmain(0bddadf).config/and the reports are not regenerated. The C is plain C (novolatile, asm,#definealiases or hardcoded addresses).Notes
What made these match, found by trying forms and comparing the output. I did not check the reasons in the compiler.
$gpoutside a delay slot are defined in the file. Retail readsD_00222460,D_0021EA98–D_0021EAAC,D_0021EC58,D_002208F4,D_002221ECandD_002203B4with$gpin ordinary slots. As described in docs/TOOLCHAIN.md,ps2eeasdoes that only for a definition it has seen, so these files define them (s32 D_x = 0;). Globals read withluistayextern.externdeclared as a struct or an array, not a scalar, keepslui+ offset.D_001F6808(u16) was otherwise reached through$gp. Infunc_L01_0046D5B8,D_00222C50andD_00222B9Casu8[]had their high halves hoisted into saved registers.func_00466458,D &= ~0x10; D &= ~0x4000;keeps twoaddiu/andpairs, as in retail. One expression folds them into a single mask. The global must also bes32: asu32,~4is built withlui/ori.forstep. Infunc_004E0218,i++, e++, flags++gives retail's order. The same increments in the body give the pointers swapped registers.addiu $sN, 6in that call's delay slot (func_L01_0046D5B8).-ffast-mathandhi < d ? hi : dgivemin.swith retail's operand order (func_L01_004FDE98), with the limits assigned in both arms of theif.🤖 Generated with Claude Code