Repository navigation
feat(rac4/ntsc): add 42 US matches and align 20 interfaces - #140
Draft
Joebannerlord wants to merge 3 commits into
Draft
Joebannerlord wants to merge 3 commits into
Joebannerlord wants to merge 3 commits into
Conversation
Allow the isolated Linux compiler routes to use a validated native scratch directory with optional invocation-only cleanup. Keep default retention, compiler inputs, flags and emitted instructions unchanged. This transport prerequisite is also proposed in PR121. Validated 10 isolated compiler tests and 18 command-route tests in the publication worktree. Rebuilt the changed upstream units with the native Windows runner; no compiler-output transformation was added. Co-Authored-By: Codex <noreply@openai.com>
Use the observed formatter/scanner variadic contracts, true helper returns and explicit target-width argument forwarding. Reconcile three newly integrated callers against their owned format metadata, including two unsigned-word scanner outputs. Preserve existing timer failure-path behavior and qualify inferred context-pointer arity. All 20 complete source units rebuild to the full retail bytes: 1,948 bytes and 91 actual relocation checks, with existing function instructions unchanged. This includes the independently integrated 0011D5D8; it is not counted as a new match. Co-Authored-By: Codex <noreply@openai.com>
Publish the independent continuation on current upstream: 3,552 new matched bytes and 93 actual relocation checks. The overlapping 0011D5D8 is an interface correction in the preceding commit, not another addition. Retain seven deferred plain-C drafts and regenerate US metadata while preserving unrelated map rows. All 62 changed units pass strict resolved-byte and ABI/call/global checks. Fresh full audits add exactly 42 matches and preserve all baseline discrepancy records. US checks and 28 relevant unit tests pass. PAL coverage remains pending (49 missing rows, local PAL inputs absent); no PAL map/report or retail inputs are included. Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 42 NTSC-U matches (3,552 bytes, 93 actual relocation checks) and reconciles 20 existing formatter/scanner/helper interfaces without changing their retail instructions. Seven plain-C near misses are retained and deferred.
The reserved batch had 43 verified local functions.
func_0011D5D8was independently integrated in #131, so it appears here as an interface correction rather than another matching addition. Three newly integrated callers also receive compatible variadic declarations and pointer forwarding. The scanner's two unsigned-word output arguments were checked against owned format metadata.This is an independent continuation on current main
0bddadfd. It does not include #121's 40 matching additions or allocator header. The optional private native scratch-storage transport prerequisite is the same small fix proposed in #121; it preserves default retention, compiler inputs, flags and emitted instructions.Validation
Draft / PAL limitation
PAL coverage reports 49 missing rows: 42 new definitions and seven retained drafts. Local RAC4 PAL retail inputs are unavailable. PAL map/report remain unchanged; no PAL equivalence is claimed. This PR stays draft pending regional coverage.
Publication notes document target-domain qualifications, the inferred unused-context interface and the preserved timer failure-path behavior. No game/runtime test is claimed.
All touched functions and the eleven total deferred cases remain reserved in our issue #112 comment until integration or explicit release. No retail data, generated assembly, toolchains or build output are included.