Skip to content

fix: handle None config and robust hparams in MambAttention (closes #449) #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
botbikamordehai2-sketch wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle None config and robust hparams in MambAttention (closes #449) #464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions deeptab/architectures/mambattention.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,15 @@ def __init__(

self.returns_ensemble = False

config = config if config is not None else MambAttentionConfig()
try:
self.pooling_method = self.hparams.pooling_method
except AttributeError:
except (AttributeError, KeyError):
self.pooling_method = config.pooling_method

try:
self.shuffle_embeddings = self.hparams.shuffle_embeddings
except AttributeError:
except (AttributeError, KeyError):
self.shuffle_embeddings = config.shuffle_embeddings

self.mamba = MambAttn(config)
Expand Down